Skip to content

[ApiManagement] Added missing 202 Accepted response code#3952

Merged
anuchandy merged 4 commits intoAzure:masterfrom
torresdal:api-management-response-code-fix
Sep 19, 2018
Merged

[ApiManagement] Added missing 202 Accepted response code#3952
anuchandy merged 4 commits intoAzure:masterfrom
torresdal:api-management-response-code-fix

Conversation

@torresdal
Copy link
Contributor

@torresdal torresdal commented Sep 19, 2018

Solves #3925

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1570

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2754

@AutorestCI
Copy link

AutorestCI commented Sep 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3641

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@azuresdkci
Copy link
Contributor

azuresdkci commented Sep 19, 2018

Can one of the admins verify this patch?

anuchandy
anuchandy requested changes Sep 19, 2018
View reviewed changes
...apimanagement/resource-manager/Microsoft.ApiManagement/stable/2017-03-01/apimdeployment.json
"description": "Accepted",
"schema": {
"$ref": "#/definitions/ApiManagementServiceResource"
}
Copy link
Member

@anuchandy anuchandy Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torresdal can you update the example for ApiManagementService_CreateOrUpdate to have 202 response as well?

Copy link
Contributor Author

@torresdal torresdal Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuchandy I added 202 to the examples listed under x-ms-examples. All good?

@msftclas
Copy link

msftclas commented Sep 19, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@AutorestCI AutorestCI mentioned this pull request Sep 19, 2018
Merged
@anuchandy anuchandy merged commit 804d486 into Azure:master Sep 19, 2018
@torresdal torresdal mentioned this pull request Sep 19, 2018
Closed
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Sep 21, 2018

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@torresdal @AutorestCI @azuresdkci @msftclas @jhendrixMSFT @anuchandy